Fix Keyboard input in HTML In App Messagess#2187
Merged
Conversation
This allows the keyboard to be displayed for text input in HTML IAMs
We want focusable on for non banner IAMs to support keyboard input, but we don't want it on for banners since it restricts interacting with the app underneath the banner
jennantilla
approved these changes
Aug 29, 2024
Merged
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Enable keyboard input for text input fields in In App Messages
Details
The popupWindow needed to be marked as focusable for non banner IAMs. Banners should remain unfocusable to allow interaction with the app underneath the popup
popupWindow?.isFocusable = !displayPosition.isBannerI also changed some force unwraps to
?. We never expect these to be null, but this is safer.Motivation
Enable text input in IAMs
Scope
IAMs
Testing
Unit testing
n/a ui
Manual testing
Tested both HTML and block built IAMs with text input.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is