Conversation
* See deprecation notice: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ * Let's update all `actions` packages to v4 * The `android-actions/setup-android` is still on release v3
jkasten2
approved these changes
Jan 31, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade
actionsfor CI due to deprecation.Details
actionspackages to v4. It looks like there is no other changes needed after bumping the version, as we have little additional configurations.android-actions/setup-androidis still on release v3 so keep the sameMotivation
Motivated by CI breaking, seen in the failure of this PR run
Also: See deprecation notice: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Scope
CI
Testing
CI now success: https://github.com/OneSignal/OneSignal-Android-SDK/actions/runs/13062566604/job/36448678877?pr=2250
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is