Merged
Conversation
Adds the following new public methods: * OneSignal.Debug.addLogListener * OneSignal.Debug.removeLogListener These new methods provide a way to capture all SDK log entires at runtime, allowing the app developer to store these and/or send them to their server. The log listener is independent of logLevel, all message are always sent to listeners.
5707ab8 to
fda14d2
Compare
Split log level and alert level logging into their own methods to make the code easier to follow.
fda14d2 to
24ed613
Compare
jinliu9508
reviewed
Jun 4, 2025
Contributor
jinliu9508
left a comment
There was a problem hiding this comment.
I added Logging.log inside the onLogEvent and it looks like it is creating logs non-stop. Should we add a note to not calling log inside the log event?
Member
Author
Given the above I don't think we need account for this. |
jinliu9508
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds the following new public methods to allow an app developer to capture logs as strings at runtime.
Details
Adds the following new public methods:
OneSignal.Debug.addLogListenerOneSignal.Debug.removeLogListenerThese new methods provide a way to capture all SDK log entires at runtime, allowing the app developer to store these and/or send them to their server.
The log listener is independent of logLevel, all message are always sent to listeners.
Motivation
App developers want a way to capture all SDK logs and send them to their server to debug issues in production.
Scope
Only add new methods to OneSignal.Debug to allow of capturing logs at runtime.
Testing
Unit testing
Added a new
LoggingTestsclass to cover the new public methods.Manual testing
Tested on an Android 15 emulator.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is