Conversation
Commit just contains the upgrades themselves, a follow up commit will includes changes required to address their build requirements.
* namespace is now always required * Some gradle.properties values were completely dropped in APG 8 * Publish release access changed to avoid build error, more changes are need to actually publish.
Since Gradle / AGP 8 upgrade the example doesn't work for Huawei builds, however this uncovered we were not correctly omitting it for all tasks. We will fix Huawei in the example project not building in follow up commit.
The top level gradle project needs a Java / Kotlin module, otherwise it skipped publishing an .aar file. While there is no code, projects consuming this SDK look for it. * Maybe we can omit the .aar on in the future for this top level project but keeping it working the same for now. Built SDK with Java 17 and tested publishing with a staging build with: * Java 11 * Gradle 7.3.3 * APG 7.2.2 * Android 5 & 14 Emulator WARNING: It is still recommended building with Java 17 instead of 21 when publishing, as those on older version of R8 will get this build error: * Cannot invoke "String.length()" because "<parameter1>" is null * See https://stackoverflow.com/q/77788162
We will need these as variables so they can be shared with future changes we are going to make to maven-push.gradle. "apply from:" doesn't have an option to share the classpath.
OSSRH is shutting down soon so we need to migrate to the Central Portal for publishing. * There are no changes to those consuming this SDK, only for mainliners to publish. Add the "plugin com.vanniktech.maven.publish" plugin to publish to the Central Portal. To publish the following command must be used now: ./gradlew publishToMavenCentral --no-configuration-cache \ -PmavenCentralUsername=USER_TOKEN_USERNAME_HERE \ -PmavenCentralPassword=USER_TOKEN_PASSWORD_HERE \ -Psigning.keyId=ID_HERE \ -Psigning.password=PASSWORD_HERE \ -Psigning.secretKeyRingFile=/FULL/PATH/TO/GPG_FILE_HERE Can switch to publishAndReleaseToMavenCentral once we do a release manually and test end-to-end.
nan-li
approved these changes
Jun 30, 2025
jinliu9508
approved these changes
Jun 30, 2025
Contributor
jinliu9508
left a comment
jinliu9508
left a comment
There was a problem hiding this comment.
Tested with several different build environments
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks PR #2264 and PR #2317 from 5.2.x into main.
Cherry picks were clean; no manual changes or extra commits.
The reason is we need both these PRs to publish new versions to maven central, as noted in PR #2317.
This change is