Merged
Conversation
nan-li
approved these changes
Jun 30, 2025
Removed noisy logging "Already instantiated" and "Found constructor" that has never been useful. Corrected "Constructor X could not find service" to be errors instead of debug.
998b451 to
6979463
Compare
jinliu9508
approved these changes
Jun 30, 2025
Contributor
jinliu9508
left a comment
There was a problem hiding this comment.
Agreed that these logs are not useful at all.
Merged
This was referenced Jul 1, 2025
nan-li
pushed a commit
that referenced
this pull request
Jul 8, 2025
…ovider Clean up logging from ServiceProvider
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Removed noisy logging "Already instantiated" and "Found constructor" that has never been useful.
Details
Also corrected "Constructor X could not find service" to be errors instead of debug.
Motivation
These extra logs always got in the way with 100s of entries and we never ever used them. This is also expected to give a very small, but still probably measurable, initialization performance improvement.
Scope
No logic changes, only effects logging of the ServiceProvider
Testing
Unit testing
No tests covering these logs to remove.
Manual testing
Tested on a Android 9 emulator.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is