Chore: Tests: fix a flaky test in StartupServiceTests#2498
Merged
jinliu9508 merged 1 commit intomainfrom Dec 1, 2025
Merged
Conversation
jkasten2
approved these changes
Dec 1, 2025
1e833ce to
98962cd
Compare
Contributor
Author
|
Rebased for the recent change |
jinliu9508
added a commit
that referenced
this pull request
Jan 6, 2026
Chore: Tests: fix a flaky test in StartupServiceTests
jinliu9508
added a commit
that referenced
this pull request
Jan 6, 2026
Chore: Tests: fix a flaky test in StartupServiceTests
jinliu9508
added a commit
that referenced
this pull request
Jan 8, 2026
Chore: Tests: fix a flaky test in StartupServiceTests
jinliu9508
added a commit
that referenced
this pull request
Jan 8, 2026
Chore: Tests: fix a flaky test in StartupServiceTests
jinliu9508
added a commit
that referenced
this pull request
Jan 8, 2026
Chore: Tests: fix a flaky test in StartupServiceTests
jinliu9508
added a commit
that referenced
this pull request
Jan 8, 2026
Chore: Tests: fix a flaky test in StartupServiceTests
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix a flaky test in StartupServiceTests that constantly failed.
Details
Scope
In the original test, there was no guarantee that all start calls in the scheduleStart will be delay. The fix add a block trigger to ensure that scheduleStart doesn't block the main thread even one of the start calls is blocking.
Testing
Unit testing
Fixed a flaky test in StartupServiceTests
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is