Skip to content

feat: add custom events part 2#152

Merged
fadi-george merged 7 commits intofg/custom-eventsfrom
fg/custom-events-2
Feb 3, 2026
Merged

feat: add custom events part 2#152
fadi-george merged 7 commits intofg/custom-eventsfrom
fg/custom-events-2

Conversation

@fadi-george
Copy link
Copy Markdown
Contributor

@fadi-george fadi-george commented Feb 3, 2026

Description

One Line Summary

  • adds custom events (trackEvent) logic and update example project to test new feature

Dashboard Logs

Screenshot 2026-02-02 at 3 16 02 PM Screenshot 2026-02-02 at 3 34 19 PM

Emulators

Screenshot 2026-02-02 at 3 39 32 PM Screenshot 2026-02-02 at 3 39 00 PM

Details

  • adds trackEvent method that call internal sdk trackEvent method
  • updates both sample apps to test trackEvent functionality
  • added for java helpers (ToNativeConversion) to convert c# dictionary to a java hashmap

Motivation

Want to support custom events for all sdks.

Manual testing

Tested android and ios emulators/simulators. See screenshots.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@fadi-george fadi-george changed the title feat: add custom events logic feat: add custom events part 2 Feb 3, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Feb 3, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Base automatically changed from fg/custom-events-1 to fg/custom-events February 3, 2026 00:23
@fadi-george fadi-george merged commit 75b7f37 into fg/custom-events Feb 3, 2026
10 checks passed
@fadi-george fadi-george deleted the fg/custom-events-2 branch February 3, 2026 00:23
fadi-george added a commit that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants