Skip to content

chore: Release 6.1.4#171

Merged
fadi-george merged 3 commits intomainfrom
rel/6.1.4
Apr 8, 2026
Merged

chore: Release 6.1.4#171
fadi-george merged 3 commits intomainfrom
rel/6.1.4

Conversation

@onesignal-deploy
Copy link
Copy Markdown
Collaborator

@onesignal-deploy onesignal-deploy commented Apr 7, 2026

Channels: Current

Deprecations

  • Deprecate LiveActivities.Exit method (currently unsupported)

Bug Fixes

  • Update Xamarin.Kotlin.StdLib.Jdk8 NuGet dependency from 1.8.0.1 to 1.9.23.3 to match the Kotlin version used by the Android SDK

🛠️ Native Dependency Updates

  • Update Android SDK from 5.7.6 to 5.7.7
    • fix: [SDK-4192] downgrade Kotlin from 2.2.0 to 1.9.25 (#2601)

@onesignal-deploy onesignal-deploy requested a review from a team as a code owner April 7, 2026 20:20
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward version bump and AAR binary update.

Extended reasoning...

Overview

This PR bumps the DotNet SDK from 6.1.3 to 6.1.4, updating the Android native SDK from 5.7.6 to 5.7.7. The only text changes are a one-line version bump in OneSignalSDK.DotNet.nuspec and a one-line Android version bump in versions.json. The remaining 4 changed files are binary AAR replacements (core, in-app-messages, location, notifications).

Security risks

None. There are no logic changes, no auth/crypto code, and no new API surfaces introduced. The native change is a Kotlin downgrade (2.2.0 → 1.9.25) in the Android SDK, which is a bug-fix release on the native side.

Level of scrutiny

Minimal — this follows the exact same mechanical pattern as prior releases (6.1.3, 6.1.2, etc.). The diff is essentially two number changes and four binary file swaps.

Other factors

The one reported bug (Kotlin stdlib NuGet dependency version mismatch) is explicitly pre-existing and predates this PR. This PR actually reduces the gap — the prior release shipped AARs compiled against Kotlin 2.2.0 with the same 1.8.0.1 stdlib declaration. Multiple prior releases shipped with this pattern without apparent runtime issues, consistent with Kotlin's strong binary compatibility guarantees. This is not a blocker for this release.

Comment thread OneSignalSDK.DotNet.nuspec
@fadi-george
Copy link
Copy Markdown
Contributor

@claude review

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — the Kotlin stdlib has been updated to 1.9.23.3, addressing the previous feedback.

Extended reasoning...

Overview

This PR bumps the OneSignal .NET SDK to 6.1.4, updating the Android native SDK from 5.7.6 to 5.7.7. The key change in the native SDK is a Kotlin downgrade from 2.2.0 to 1.9.25. The diff touches: 4 Android binding csproj files, the main Android csproj, the nuspec, versions.json, 4 AAR binaries, and a deleted Cursor IDE rules file.

Security Risks

No security-sensitive code is touched. This is a version bump and dependency update with no auth, crypto, or permissions changes.

Level of Scrutiny

Low. This follows the same pattern as prior release PRs (e.g., 6.1.3). The changes are mechanical: version numbers incremented, binaries swapped, and dependency versions updated to match. The prior concern about Kotlin stdlib version mismatch has been fully addressed — Xamarin.Kotlin.StdLib.Jdk8 is now 1.9.23.3, consistent with the 1.9.25 Kotlin version used to compile the AARs.

Other Factors

No bugs were found by the automated bug hunting system. The previous inline comment was marked resolved, and the fix directly corresponds to the suggestion made. No outstanding reviewer comments remain.

@fadi-george fadi-george merged commit 406889e into main Apr 8, 2026
9 checks passed
@fadi-george fadi-george deleted the rel/6.1.4 branch April 8, 2026 23:21
@claude claude Bot mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants