Android plugin API updated to support v2 Embedding

[luis901101]

As requested here Issue 480, it's necessary to update the Android implementation to support the v2 Embedding which it's the default for new Android plugins and it is highly recommended to be update it because future release of Flutter will fail to build with deprecated Android embedding.
I migrated the Android implementation to support embedding v2 while remaining compatible with apps that don’t use the v2 Android embedding.

---

This change is 

[danielgomezrico]

@Jeasmine any chance to check this?

[charlesarchibong]

@emawby please can you review

[emawby]

Reviewed 1 of 23 files at r1.
Reviewable status: 1 of 23 files reviewed, 4 unresolved discussions (waiting on @emawby and @luis901101)

a discussion (no related file):
Thank you so much for the contribution this looks great! I would like to clean this PR up to only the required changes if possible. There are a lot of changes to files in .idea and gradle versions. Are all of those changes necessary?

---

---

.idea/modules.xml, line 5 at r1 (raw file):

  <component name="ProjectModuleManager">
    <modules>
      <module fileurl="file://$PROJECT_DIR$/.idea/onesignal_flutter_official_fork.iml" filepath="$PROJECT_DIR$/.idea/onesignal_flutter_official_fork.iml" />

I don't think we want to commit this change to the main branch

---

android/build.gradle, line 11 at r1 (raw file):

    dependencies {
        classpath 'com.android.tools.build:gradle:3.5.3'

Is this gradle version bump required for these changes?

---

android/gradle/wrapper/gradle-wrapper.properties, line 6 at r1 (raw file):

zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.2-all.zip

Is this gradle version change required?

[luis901101]

Nop, those changes you ask are not required at all.

[jkasten2]

@luis901101 Appreciate the contribution here! I reviewed your PR as well and the changes to the logic to support the Flutter V2 Android API themselves look good. However as @emawby noted there are unrelated changes to project files, some not compatible with main.

@luis901101 If you can address those comments and remove any changes you know are not necessary we can merge this PR in. If your not in a good position to make these changes this week let us know and we can make the needed changes.

[luis901101]

Ok, I'll remove those changes

[jkasten2]

Thanks for the clean up, looks good to me!
@emawby If you want to take another quick pass at the comments you left and approve one of us can merge it in.

[danielgomezrico]

@luis901101 after some change that you pushed we get a failure getting the dependency from github:

Could not find a file named "pubspec.yaml" in https://github.com/luis901101/OneSignal-Flutter-SDK.git 8d2013eb05a5779a3e19d4bb20dd16a8d5aa90b7.

It looks like that commit that we were referencing does not exist anymore, maybe you changed the history somehow?

[luis901101]

@luis901101 after some change that you pushed we get a failure getting the dependency from github:

Could not find a file named "pubspec.yaml" in https://github.com/luis901101/OneSignal-Flutter-SDK.git 8d2013eb05a5779a3e19d4bb20dd16a8d5aa90b7.

It looks like that commit that we were referencing does not exist anymore, maybe you changed the history somehow?

Yep after I removed unnecessary file changes from PR yesterday that commit is not available any more, the commit now is 952e78c1c6f7ace65082914f4e90f6667b6b382c... but I don't understand why you get that error... are you referencing that commit directly in your pubpsec depedencies ? If that's the case I recommend you to reference the branch like this:

onesignal_flutter: #^3.2.3
    git:
      url: https://github.com/luis901101/OneSignal-Flutter-SDK.git
      ref: migrate_android_embedding_v2

That way does not matter the commit, it will download the latest commit to that branch which is the one I did yesterday.

[danielgomezrico]

@luis901101 yeah, when you do a pub get it reference a commit in the pubspec.lock.

It's awesome that the PR was merged!

[jesselopespereira]

Great PR @luis901101, congrats for your efforts.

[nmarko91]

Hello, just curious, any update to release a new version from main branch that has this PR so we don't have to target a specific branch?