chore: add warning for identity verification#901
Merged
jennantilla merged 2 commits intoOneSignal:mainfrom Jul 3, 2024
zvikarp:main
Merged
chore: add warning for identity verification#901jennantilla merged 2 commits intoOneSignal:mainfrom zvikarp:main
jennantilla merged 2 commits intoOneSignal:mainfrom
zvikarp:main
Conversation
Contributor
Author
|
this is related to OneSignal/OneSignal-Android-SDK#1913 |
Contributor
Author
|
Hi @jennantilla @nan-li or the rest of the team, is there any blocker form merging this? |
Contributor
|
Hi @zvikarp thanks for submitting this PR, this method should not have been exposed when the functionality is not yet ready. |
nan-li
approved these changes
Jun 26, 2024
jkasten2
approved these changes
Jun 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
This method is misleading. it is not implemented but the package exposes it. Please remove it or annotate it.
Details
Errors from Android in device logs:
Error from iOS in API request:
curl:
response:
Documentation that mentions it is not implemented: https://documentation.onesignal.com/docs/identity-verification.
Motivation
I spent hours trying to figure out why I'm getting null for onesignal id, no errors in the code logging but different errors from device logs and apis for ios and android didn't help either.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is