Skip to content

Removed duplicate "longer" MIGRATION_GUIDE.md#914

Merged
jennantilla merged 1 commit intoOneSignal:mainfrom
Sikandar4747:main
Aug 15, 2024
Merged

Removed duplicate "longer" MIGRATION_GUIDE.md#914
jennantilla merged 1 commit intoOneSignal:mainfrom
Sikandar4747:main

Conversation

@Sikandar4747
Copy link
Copy Markdown
Contributor

@Sikandar4747 Sikandar4747 commented Jun 27, 2024

Description

One Line Summary

Removed duplicate "longer" MIGRATION_GUIDE.md

Details

Motivation

REQUIRED - This ensures better readability for the one signal flutter docs.

Scope

RECOMMEND - OPTIONAL - Migration guide docs.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • [] I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jennantilla
Copy link
Copy Markdown
Contributor

Thanks for catching, @Sikandar4747!

@jennantilla jennantilla merged commit d0f019a into OneSignal:main Aug 15, 2024
@jennantilla jennantilla mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants