Release 3.12.8#1388
Merged
nan-li merged 7 commits intoplayer-model-mainfrom Mar 19, 2024
Merged
Conversation
emawby
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New Features
About code signing
I signed the 4 xcframeworks after building the binaries.
I used the OneSignal org to sign the 4 xcframeworks, and confirmed the information provided to the SDK consumer by pointing to this PR.
I was not able to test SPM since I believe it may not be used by SPM, and using a commit or branch from OneSignal-XCFramework was not sufficient, since SPM went looking for the tagged 3.12.8 release anyway.
This change is