[3.x.x] Replace deprecated openURL method preventing launch URLs#1493
Merged
nan-li merged 2 commits intoplayer-model-mainfrom Oct 7, 2024
Merged
[3.x.x] Replace deprecated openURL method preventing launch URLs#1493nan-li merged 2 commits intoplayer-model-mainfrom
nan-li merged 2 commits intoplayer-model-mainfrom
Conversation
* openURL: is completely deprecated on ios 18, so replace with the updated openURL:options:completionHandler:
* `macos-latest` recently migrated from macos-12 to macos-14 Arm64, the latter of which does not ship with swiftlint * `macos-latest-large` is also a macos-14 image and does ship with swiftlint
emawby
approved these changes
Oct 7, 2024
Contributor
Author
|
The CI environment may have changed. Ran this CI 3 times, all had some tests failing after 10-11 minutes. Passes locally. |
Merged
This was referenced Oct 7, 2024
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
The method
openURL:(doc) appears to be completely deprecated on ios 18, so replace with the updatedopenURL:options:completionHandler:(doc).Details
Motivation
Tapping on launch URLs fails with iOS 18 when using the deprecated method.
The user model SDK already uses the newer API.
Scope
Update a deprecated method with its replacement in 2 places (both are tested).
Testing
Unit testing
None
Manual testing
iPhone 16 simulator on iOS 18.0
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is