Fix notification launchUrl changed to launchURL to make it compatible…#1704
Merged
nan-li merged 1 commit intoOneSignal:mainfrom Jun 5, 2024
Merged
Fix notification launchUrl changed to launchURL to make it compatible…#1704nan-li merged 1 commit intoOneSignal:mainfrom
nan-li merged 1 commit intoOneSignal:mainfrom
Conversation
nan-li
approved these changes
May 14, 2024
Contributor
nan-li
left a comment
There was a problem hiding this comment.
Hi @hakansaglam29 thank you for submitting this PR. I went ahead and edited the PR description.
jennantilla
approved these changes
May 21, 2024
|
@jennantilla @nan-li Is this going to be merged soon? |
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes a wrong Android name for
launchURLDetails
Motivation
launchURLdiffers between iOS and Android implementation #1635Scope
RECOMMEND - OPTIONAL - What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.
OPTIONAL - Other
OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
RECOMMEND - OPTIONAL - Explain what scenarios were tested and the environment.
Example: Tested opening a notification while the app was foregrounded, app build with Android Studio 2020.3 with a fresh install of the OneSignal example app on a Pixel 6 with Android 12.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is