fix: [SDK-4390] bump react-native peer dep to >=0.79.0 for TurboModule support#1944
Merged
fadi-george merged 2 commits intomainfrom Apr 28, 2026
Conversation
sherwinski
approved these changes
Apr 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Bump the
react-nativepeer dependency to>=0.79.0and document the requirement so apps on RN 0.76 to 0.78 don't hit a runtimeTurboModuleRegistry.getEnforcing(...): 'OneSignal' could not be foundcrash.Details
Motivation
Reported in #1943. On Expo SDK 52 / RN 0.76 with the New Architecture enabled,
react-native-onesignal@5.4.xcrashes at JS startup withInvariant Violation: TurboModuleRegistry.getEnforcing(...): 'OneSignal' could not be found. Root cause: 5.4.x registers its iOS TurboModule through thecodegenConfig.ios.modulesProviderfield inpackage.json, which was added in React Native 0.79. On 0.79+, codegen emits anRCTModuleProviders.mmshim that registers the module withRCTAppDependencyProvider. RN 0.76 silently ignores the field, no shim is generated, and bridgeless TurboModule lookup fails. The peer dep currently advertises>=0.76.0, which is why this isn't caught at install time.Scope
peerDependencies.react-nativefrom>=0.76.0to>=0.79.0inpackage.json.README.mdcalling out the RN 0.79 floor.MIGRATION_GUIDE.mdfor v5.4.x.Testing
Manual testing
Reproduced the crash end to end using a fresh Expo SDK 52 / RN 0.76 / new arch project with
react-native-onesignal@5.4.3:modulesProviderorRCTModuleProvider, while RN 0.81.5 has the full template/generator stack.expo prebuild+pod installproduces noRCTModuleProviders.mmorRCTAppDependencyProvider.mmon RN 0.76; demo2 on RN 0.81 generates both with the OneSignal entry.TurboModuleRegistry.getEnforcing('OneSignal')throws the exact Invariant Violation from the issue.After the peer dep bump, npm/yarn/pnpm/bun will warn (or error in strict modes) on incompatible RN versions before the user hits the runtime crash.
Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor