fix(auth): add API key expiry support (E2-3) (#1436)#1540
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 9, 2026
Merged
fix(auth): add API key expiry support (E2-3) (#1436)#1540OneStepAt4time merged 1 commit intodevelopfrom
OneStepAt4time merged 1 commit intodevelopfrom
Conversation
Add expiresAt field to ApiKey interface. Keys created with optional ttlDays parameter will be rejected by validate() once expired. Existing keys without expiresAt (null) remain valid indefinitely — fully backward compatible. Generated by Hephaestus (Aegis dev agent)
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Approved. API key expiry support (E2-3, Issue #1436). Clean implementation: optional ttlDays param, expiresAt field with null=never, validation rejects expired keys, backward compatible. 4 files, 126 lines, CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expiresAt: number | nulltoApiKeyinterface (Unix timestamp in ms)createKey()accepts optionalttlDaysparameter; computesexpiresAtwhen providedvalidate()rejects keys whereexpiresAtis in the pastexpiresAt(null) remain valid — fully backward compatibleauthStoreSchemadefaultsexpiresAttonullfor persisted stores missing the fieldPOST /v1/auth/keysaccepts optionalttlDaysin request bodyCloses #1436
Test plan
tsc --noEmitpassesnpm run buildpassesnpm testpasses (2573 tests)validate()Aegis version
Developed with: v0.3.2-alpha
Generated by Hephaestus (Aegis dev agent)