fix(reliability): add LRU eviction to TmuxCaptureCache (#1433)#1542
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 9, 2026
Merged
fix(reliability): add LRU eviction to TmuxCaptureCache (#1433)#1542OneStepAt4time merged 1 commit intodevelopfrom
OneStepAt4time merged 1 commit intodevelopfrom
Conversation
- Add configurable maxEntries (default 100) with LRU eviction - Move accessed entries to most-recent position on cache hit - Add invalidateSession() for bulk cleanup of dead session entries - Add size getter for diagnostics - Comprehensive test coverage for eviction, LRU ordering, and session cleanup
Contributor
There was a problem hiding this comment.
✅ Approved. LRU eviction for TmuxCaptureCache (#1433). Clean implementation using Map insertion order for true LRU. maxEntries default 100, session invalidation, size getter. 5 new tests. 2 files, CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TmuxCaptureCache had no eviction policy — dead session entries accumulated indefinitely, causing unbounded memory growth.
Changes
maxEntries(default 100). When exceeded, oldest entries are evicted.invalidateSession(prefix)method to bulk-remove entries for ended sessions.sizegetter for monitoring cache usage.Tests
Closes #1433