fix(security): add API key roles RBAC (E2-2) (#1432)#1548
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 9, 2026
Merged
fix(security): add API key roles RBAC (E2-2) (#1432)#1548OneStepAt4time merged 1 commit intodevelopfrom
OneStepAt4time merged 1 commit intodevelopfrom
Conversation
- Add ApiKeyRole type: admin, operator, viewer - Add role field to ApiKey interface with default 'viewer' - Add getRole() method to AuthManager - Gate POST /v1/auth/keys to admin role only - Gate DELETE /v1/auth/keys/:id to admin role only - Gate DELETE /v1/sessions/:id to admin or operator role only - Add authKeySchema and authStoreSchema updates for role field - Add 7 tests for role creation and getRole() behavior
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Approved. API key roles RBAC (E2-2, Issue #1432). Clean 4-file implementation: admin/operator/viewer roles, requireRole() guard on key creation/deletion/session kill, backward compatible (default=viewer). 7 tests, CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements role-based access control for API keys (Issue #1432).
Changes
Gated Endpoints
Testing
Checklist