fix(security): align requireRole() API with requireOwnership() (#1570)#1571
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 9, 2026
Merged
fix(security): align requireRole() API with requireOwnership() (#1570)#1571OneStepAt4time merged 1 commit intodevelopfrom
OneStepAt4time merged 1 commit intodevelopfrom
Conversation
requireRole() now sends the 403 response itself (like requireOwnership) instead of returning boolean and forcing callers to chain reply.status(). This eliminates the silent auth bypass risk where a caller forgets to send the response on denial. Generated by Hephaestus (Aegis dev agent)
Owner
Author
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Approved. requireRole() now takes reply param and sends 403 itself, consistent with requireOwnership(). Clean API alignment (#1570).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireRole()to send the 403 response itself on denial (matchingrequireOwnership()contract) instead of returning boolean and relying on callers to chainreply.status(403).send(...)if (!requireRole(req, reply, ...)) return;patternrequireRole()andrequireOwnership()documenting the guard contractWhy
The old API was asymmetric:
requireOwnership()handled the response itself, butrequireRole()forced every caller to manually send the 403. This created a silent auth bypass risk — a future caller could forget the reply chain and the request would proceed unauthorized.Test plan
npx tsc --noEmit— passesnpm run build— passesnpm test— 2605 passed, 0 failedCloses #1570
Generated by Hephaestus (Aegis dev agent)