fix: add global defaultStageTimeoutMs for pipeline stages (#1423)#1606
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 10, 2026
Merged
fix: add global defaultStageTimeoutMs for pipeline stages (#1423)#1606OneStepAt4time merged 1 commit intodevelopfrom
OneStepAt4time merged 1 commit intodevelopfrom
Conversation
- Add pipelineStageTimeoutMs config with AEGIS_PIPELINE_STAGE_TIMEOUT_MS env var - PipelineManager constructor accepts defaultStageTimeoutMs (0 = no timeout) - Per-stage stageTimeoutMs overrides global default - Timeout check happens BEFORE idle check (timeout wins over idle) - Add 3 new tests: global default, per-stage override, timeout wins over idle
Contributor
There was a problem hiding this comment.
✅ Approved.
Fixes #1423 — Global default pipeline stage timeout.
Same clean implementation as original #1586, correctly ported to current develop.
Key points:
- New
AEGIS_PIPELINE_STAGE_TIMEOUT_MSenv var (default 0 = no timeout, backward compatible) - Timeout checked BEFORE idle — correct priority
- Per-stage
stageTimeoutMsoverrides global default via nullish coalescing - 3 test cases: default timeout, per-stage override, timeout-wins-over-idle
parseIntSafefor env var parsing- 4 files, 119 lines. CI green.
OneStepAt4time
pushed a commit
that referenced
this pull request
Apr 10, 2026
…1583) Remove all documentation references to deleted features (PR #1583). REMOVED FEATURES: - Consensus Review endpoints (/v1/sessions/:id/consensus, /v1/consensus/:id) - Model Router config and tiered routing FILES CHANGED: - README.md: Remove consensus/model router from features list - docs/advanced.md: Remove Consensus Review section - docs/api-reference.md: Remove consensus endpoints; remove consensus.completed SSE event - docs/architecture.md: Remove consensus.ts and model-router.ts from module overview - docs/getting-started.md: Update advanced features reference - docs/enterprise.md: Remove modelRouter from config example - docs/enterprise/01-architecture.md: Remove consensus/model-router; mark findings RESOLVED - docs/enterprise/03-testing-observability.md: Remove model-router.ts from thin-tests list - docs/enterprise/05-enterprise-roadmap.md: Remove E4-1 (consensus); update M-E4 scope - docs/enterprise/index.md: Remove consensus reliability finding RESOLVED IN v0.3.3: - P-3 (PipelineManager persistence): PR #1585 - P-1 (Pipeline stage timeout): PR #1606 - CON-1 (Consensus): PR #1583 (feature removed) NOTE: openapi.yaml still contains /consensus endpoints — separate update needed.
OneStepAt4time
pushed a commit
that referenced
this pull request
Apr 12, 2026
…1583) Remove all documentation references to deleted features (PR #1583). REMOVED FEATURES: - Consensus Review endpoints (/v1/sessions/:id/consensus, /v1/consensus/:id) - Model Router config and tiered routing FILES CHANGED: - README.md: Remove consensus/model router from features list - docs/advanced.md: Remove Consensus Review section - docs/api-reference.md: Remove consensus endpoints; remove consensus.completed SSE event - docs/architecture.md: Remove consensus.ts and model-router.ts from module overview - docs/getting-started.md: Update advanced features reference - docs/enterprise.md: Remove modelRouter from config example - docs/enterprise/01-architecture.md: Remove consensus/model-router; mark findings RESOLVED - docs/enterprise/03-testing-observability.md: Remove model-router.ts from thin-tests list - docs/enterprise/05-enterprise-roadmap.md: Remove E4-1 (consensus); update M-E4 scope - docs/enterprise/index.md: Remove consensus reliability finding RESOLVED IN v0.3.3: - P-3 (PipelineManager persistence): PR #1585 - P-1 (Pipeline stage timeout): PR #1606 - CON-1 (Consensus): PR #1583 (feature removed) NOTE: openapi.yaml still contains /consensus endpoints — separate update needed.
OneStepAt4time
added a commit
that referenced
this pull request
Apr 12, 2026
…1583) (#1709) Remove all documentation references to deleted features (PR #1583). REMOVED FEATURES: - Consensus Review endpoints (/v1/sessions/:id/consensus, /v1/consensus/:id) - Model Router config and tiered routing FILES CHANGED: - README.md: Remove consensus/model router from features list - docs/advanced.md: Remove Consensus Review section - docs/api-reference.md: Remove consensus endpoints; remove consensus.completed SSE event - docs/architecture.md: Remove consensus.ts and model-router.ts from module overview - docs/getting-started.md: Update advanced features reference - docs/enterprise.md: Remove modelRouter from config example - docs/enterprise/01-architecture.md: Remove consensus/model-router; mark findings RESOLVED - docs/enterprise/03-testing-observability.md: Remove model-router.ts from thin-tests list - docs/enterprise/05-enterprise-roadmap.md: Remove E4-1 (consensus); update M-E4 scope - docs/enterprise/index.md: Remove consensus reliability finding RESOLVED IN v0.3.3: - P-3 (PipelineManager persistence): PR #1585 - P-1 (Pipeline stage timeout): PR #1606 - CON-1 (Consensus): PR #1583 (feature removed) NOTE: openapi.yaml still contains /consensus endpoints — separate update needed. Co-authored-by: Argus <argus@openclaw.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add global default stage timeout for pipeline stages.
Changes
Behavior
Tests
3 new tests added:
PR Stats