fix: return stall feedback in send_message response (#1325)#1612
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 10, 2026
Merged
fix: return stall feedback in send_message response (#1325)#1612OneStepAt4time merged 1 commit intodevelopfrom
OneStepAt4time merged 1 commit intodevelopfrom
Conversation
When a session is stalled (extended thinking, permission prompt, unknown state), send_message now includes stall information in the response so callers know the session may not process the message. - Add SessionMonitor.getStallInfo() to query active stall types - Thread stall info through sendMessage() → HTTP/MCP response - Add stall field to SendMessageResponse interface - Add tests for getStallInfo covering tracked, cleared, and removed sessions Generated by Hephaestus (Aegis dev agent)
Owner
Author
|
🔧 PR #1612 CLEAN. Ready for review. |
Contributor
There was a problem hiding this comment.
✅ Approved.
Issue #1325 — Surface stall info in send_message response.
Clean implementation:
SessionMonitor.getStallInfo()returns active stall types or{ stalled: false }- Propagated through
sendMessage()→ API response → MCP tool - MCP tool description updated to document stall feedback
- 4 test cases: no stall, multiple stall types, cleared stalls, removed session
- No breaking changes —
stallfield is optional in response
5 files, 65 lines. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_messagereturns no feedback when session is stalledsendMessage()only returned{delivered, attempts}with no awareness of stall stateSessionMonitor.getStallInfo()before sending and include stall info in the responseChanges
getStallInfo(sessionId)method — returns{stalled: true, types: [...]}or{stalled: false}sendMessage()accepts optionalstallInfoparam, includes it in return when providedstallfield in responseSendMessageResponseinterface and tool description to surface stall infogetStallInfo(empty, active, cleared, removed)Response examples
Not stalled:
{ "ok": true, "delivered": true, "attempts": 1 }Stalled (extended thinking):
{ "ok": true, "delivered": true, "attempts": 1, "stall": { "stalled": true, "types": ["thinking"] } }Stalled (permission prompt):
{ "ok": true, "delivered": true, "attempts": 1, "stall": { "stalled": true, "types": ["permission"] } }Test plan
npx tsc --noEmit— no new type errorsnpm test— 5521 tests pass (4 new)stallfield in responseAegis version
Developed with: v2.9.0
Closes #1325
Generated by Hephaestus (Aegis dev agent)