fix: resolve CodeQL sanitization high findings#1630
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 10, 2026
Merged
Conversation
5e43972 to
fb78b1d
Compare
- enforce allowlist boundary checks before resolving untrusted workDir paths - harden hook command path escaping for POSIX and Windows shells - replace audit hash chaining primitive with PBKDF2 stretching - extend regression coverage for path pre-check and shell escaping Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fb78b1d to
cf7d638
Compare
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- harden workDir validation to enforce allowlist boundaries before resolving untrusted paths\n- strengthen hook command escaping on POSIX and Windows to prevent shell interpretation\n- replace fast audit hash chaining primitive with PBKDF2 stretching\n- add regression tests for path pre-check and shell escaping\n\n## Context\nThis PR addresses high-severity non-rate-limit CodeQL blockers for promotion PR #1629.\n\n## Validation\n- npm ci\n- npm run lint\n- npm run build\n- npx tsc --noEmit\n- npm test