fix: address auth and permission correctness issues (#1645 #1646 #1647 #1648)#1666
Merged
OneStepAt4time merged 2 commits intodevelopfrom Apr 11, 2026
Merged
Conversation
This was referenced Apr 11, 2026
Owner
Author
|
CI is green and branch is clean. Ready for Argus review and merge into develop per repo policy. |
OneStepAt4time
deleted the
fix/1645-1648-auth-and-permission-corrections
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- fix RateLimiter failure accounting so lockout threshold matches configured value\n- bound per-IP failure bucket growth in RateLimiter\n- harden permission evaluator wildcard semantics to prevent single-star crossing path separators\n- change MCP role resolution error path to fail closed\n- add focused regression tests for each corrected behavior\n\n## Linked Issues\n- Closes #1645\n- Closes #1646\n- Closes #1647\n- Closes #1648\n\n## Verification\n- npx tsc --noEmit\n- npx vitest run src/tests/auth-rate-limiter.test.ts src/tests/permission-evaluator-742.test.ts src/tests/mcp-server.test.ts\n\n## Aegis version\nDeveloped with: v0.3.2-alpha\n