fix: extract cross-platform shell abstraction layer#1701
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 12, 2026
Merged
fix: extract cross-platform shell abstraction layer#1701OneStepAt4time merged 1 commit intodevelopfrom
OneStepAt4time merged 1 commit intodevelopfrom
Conversation
- Create src/platform/shell.ts with shellEscape, quoteShellArg, buildClaudeLaunchCommand, runShellScript, isPidAlive - runShellScript uses powershell on Windows instead of sh (fixes #1692) - isPidAlive uses /proc/<pid>/stat zombie check on POSIX - Refactor tmux.ts to import from platform/shell.ts - Add 13 unit tests for platform-shell module Closes #1694 Fixes #1692
This was referenced Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract platform-specific shell execution logic from \ mux.ts\ into a dedicated \src/platform/shell.ts\ module. This fixes the Windows \spawn sh ENOENT\ error (#1692) by using PowerShell on Windows instead of hardcoded \sh.
Changes
unShellScript()\ — uses \powershell.exe\ on Windows, \sh\ on POSIX
Testing
px tsc --noEmit\ — clean
pm run build\ — passes
pm test\ — 159 passed, 0 failed (2814 tests total)
Aegis version
Developed with: v0.3.2-alpha
Closes #1694
Fixes #1692