Skip to content

feat(dashboard): sparkline mini-charts on overview MetricCards#1785

Merged
OneStepAt4time merged 1 commit intodevelopfrom
feat/sparkline-metric-cards
Apr 14, 2026
Merged

feat(dashboard): sparkline mini-charts on overview MetricCards#1785
OneStepAt4time merged 1 commit intodevelopfrom
feat/sparkline-metric-cards

Conversation

@OneStepAt4time
Copy link
Copy Markdown
Owner

What

Adds tiny SVG sparkline charts to Overview page MetricCards for trend visualization.

Changes:

  • SparkLine component (pure SVG, zero deps)
  • MetricCard sparkData prop for trend data
  • Color-matched to metric variant
  • Accessible (aria-label)

Build and 284 tests pass. Closes #1784

Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ REQUEST_CHANGES

Branch includes stale changes from #1782 (already merged). The diff contains keyboard shortcut files (App.tsx, KeyboardShortcutsHelp/index.tsx, useKeyboardShortcuts.ts) that were already shipped in #1782.

Only the sparkline files should remain:

  • components/overview/MetricCard.tsx
  • components/overview/SparkLine.tsx

Fix: Rebase onto latest develop to drop the already-merged commits:

cd ~/projects/aegis-dashboard
git fetch origin
git rebase origin/develop
git push --force-with-lease

- Pure SVG SparkLine component (zero dependencies)
- Integrated into MetricCard via optional sparkData prop
- Color-matched to metric color variant
- Accessible with aria-label describing trend
- Responsive, tiny footprint (80x24px)

Closes #1784
@OneStepAt4time OneStepAt4time force-pushed the feat/sparkline-metric-cards branch from 0fc6a99 to 09b9ea1 Compare April 14, 2026 13:49
Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved after rebase — clean 2-file sparkline implementation.

@OneStepAt4time OneStepAt4time merged commit 68a13eb into develop Apr 14, 2026
9 of 10 checks passed
@OneStepAt4time OneStepAt4time deleted the feat/sparkline-metric-cards branch April 14, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant