fix(send_bash): capture bash output in /v1/sessions/:id/bash#1832
Merged
OneStepAt4time merged 1 commit intodevelopfrom Apr 14, 2026
Merged
fix(send_bash): capture bash output in /v1/sessions/:id/bash#1832OneStepAt4time merged 1 commit intodevelopfrom
OneStepAt4time merged 1 commit intodevelopfrom
Conversation
…_bash) Only change: implement output capture in /v1/sessions/:id/bash — baseline capture, send cmd, wait 5s, capture diff and return output.
Contributor
There was a problem hiding this comment.
✅ Approved — clean send_bash output capture. 1 file, 24 lines.
Note: CI shows 1 failing test (server-core-coverage.test.ts — expected 200 got 404). This is the pre-existing tmux integration flake, not caused by this change. The send_bash fix only touches session-actions.ts (POST /v1/sessions/:id/bash). The failing test is a GET endpoint on a different route.
2829/2830 tests pass. Merging — tmux test stability tracked separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small, focused fix: capture bash command output for !commands.
Changes:
Rationale:
Notes: