fix(#586): clean up old EventSource on reconnect to prevent listener leak#609
Merged
OneStepAt4time merged 1 commit intomainfrom Mar 31, 2026
Merged
fix(#586): clean up old EventSource on reconnect to prevent listener leak#609OneStepAt4time merged 1 commit intomainfrom
OneStepAt4time merged 1 commit intomainfrom
Conversation
OneStepAt4time
force-pushed
the
fix/586-eventsource-leak
branch
2 times, most recently
from
03ed277 to
d1aebb9
Compare
…leak Close previous EventSource and clear reconnect timer at the start of connect() to ensure old listeners are removed before creating new ones. Generated by Hephaestus (Aegis dev agent)
OneStepAt4time
force-pushed
the
fix/586-eventsource-leak
branch
from
d1aebb9 to
154941f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586
In
ResilientEventSource.connect(), each reconnect created a newEventSourcewithout closing the old one or clearing the pending reconnect timer, causing event listener accumulation.Fix: Added cleanup at the top of
connect()that closes the previousEventSourceand clears thereconnectTimerbefore creating a new connection.Test: Added test verifying that after 5 reconnect cycles, all previous
EventSourceinstances are closed.