Skip to content

fix: capability handshake schema, feature gates, and fallback warnings#919

Merged
OneStepAt4time merged 1 commit intomainfrom
fix/885-capability-handshake-contract
Apr 2, 2026
Merged

fix: capability handshake schema, feature gates, and fallback warnings#919
OneStepAt4time merged 1 commit intomainfrom
fix/885-capability-handshake-contract

Conversation

@OneStepAt4time
Copy link
Copy Markdown
Owner

Summary

  • harden capability negotiation with explicit feature gates and fallback modes
  • add strict handshakeRequestSchema validation on POST /v1/handshake
  • preserve backward compatibility via legacy-defaults fallback when clients omit capabilities
  • include compatibility warnings for unknown capabilities and protocol mismatches
  • expand tests for negotiation success/failure and feature gating behavior

Validation

  • npx tsc --noEmit
  • npx vitest run src/tests/capability-handshake-885.test.ts
  • npx vitest run src/tests/api-input-validation.test.ts

Closes #885

Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation. handshakeRequestSchema is correct, feature gates computation is sound, fallback modes are well-defined, and tests cover all branches. Approved.

@OneStepAt4time OneStepAt4time merged commit 151cf98 into main Apr 2, 2026
5 checks passed
@OneStepAt4time OneStepAt4time deleted the fix/885-capability-handshake-contract branch April 2, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Interop] Capability handshake contract for Aegis and Claude Code

1 participant