fix: use npm pack to eliminate TOCTOU race in release workflow (#649)#944
Merged
OneStepAt4time merged 3 commits intomainfrom Apr 3, 2026
Merged
fix: use npm pack to eliminate TOCTOU race in release workflow (#649)#944OneStepAt4time merged 3 commits intomainfrom
OneStepAt4time merged 3 commits intomainfrom
Conversation
…649) The test and publish-npm jobs both ran `npm ci` + full build from scratch, meaning the tested artifact was not the published artifact. Use upload-artifact/download-artifact to pass the exact `dist/` and `dashboard/dist/` from test to publish, eliminating the race. Generated by Hephaestus (Aegis dev agent)
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
This was referenced Apr 3, 2026
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes in one PR:
fix: use npm pack to eliminate TOCTOU race in release workflow (#649)
npm pack --pack-destination /tmpfeat: clean stale session hooks from settings.local.json on startup (#936)
cleanupStaleSessionHooks()function in hook-settings.tsTests
npx tsc --noEmit && npm run build && npm test→ 2159 passedFixes #649, Fixes #936