Skip to content

fix: preserve hook env vars and normalize callback host#981

Merged
OneStepAt4time merged 1 commit intomainfrom
fix/979-hook-settings-env-loopback
Apr 3, 2026
Merged

fix: preserve hook env vars and normalize callback host#981
OneStepAt4time merged 1 commit intomainfrom
fix/979-hook-settings-env-loopback

Conversation

@OneStepAt4time
Copy link
Copy Markdown
Owner

Summary

  • preserve project env vars from .claude/settings.local.json even when schema validation fails on unrelated fields
  • normalize hook callback base URL from 0.0.0.0 / :: to 127.0.0.1 so CC can reach Aegis callbacks
  • add regression tests for both env preservation and callback host normalization

Validation

  • npx vitest run src/__tests__/hook-settings.test.ts
  • npx tsc --noEmit

Closes #979

Aegis version

Developed with: v2.9.2

@OneStepAt4time OneStepAt4time force-pushed the fix/979-hook-settings-env-loopback branch from 4416c6e to 4d86227 Compare April 3, 2026 15:38
@OneStepAt4time
Copy link
Copy Markdown
Owner Author

@aegis-gh-agent urgent: CI is fully green, branch rebased on main. Please review.

Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hook settings env preservation and callback URL normalization. Approved.

@aegis-gh-agent
Copy link
Copy Markdown
Contributor

aegis-gh-agent bot commented Apr 3, 2026

Self-rebase failed — conflicts with merged dashboard PRs across AccessibilityIssue309.test.tsx, SessionTable.test.tsx, client.ts, types/index.ts, hook-settings.ts. Please close this PR, rebase the branch onto current main, and open a new PR.

@OneStepAt4time OneStepAt4time force-pushed the fix/979-hook-settings-env-loopback branch from 4d86227 to f4082a5 Compare April 3, 2026 15:54
@aegis-gh-agent
Copy link
Copy Markdown
Contributor

aegis-gh-agent bot commented Apr 3, 2026

Self-rebase failed — same cascade as #980. Both need coordinated rebase onto current main.

@OneStepAt4time OneStepAt4time merged commit 319e478 into main Apr 3, 2026
5 checks passed
@OneStepAt4time OneStepAt4time deleted the fix/979-hook-settings-env-loopback branch April 3, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hook settings missing ZAI env vars and using 0.0.0.0 in webhook URLs

1 participant