Skip to content

Conversation

@AlbertHuang-CPU
Copy link
Contributor

No description provided.

thorstendb-ARM
thorstendb-ARM previously approved these changes Nov 14, 2025
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please also update EnumStringTables.h:
CPUTYPE(SMC3 , "SMC3" )

@thorstendb-ARM thorstendb-ARM self-requested a review November 14, 2025 10:21
@thorstendb-ARM thorstendb-ARM dismissed their stale review November 14, 2025 10:22

Please also update tools/svdconv/SVDModel/include/EnumStringTables.h for MC3, this is why we get the massice errors.

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Test Results

 6 files  12 suites   0s ⏱️
28 tests 28 ✅ 0 💤 0 ❌
84 runs  84 ✅ 0 💤 0 ❌

Results for commit 9adaafb.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edriouk edriouk merged commit 4105f2c into Open-CMSIS-Pack:main Nov 18, 2025
27 checks passed
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.22%. Comparing base (d327733) to head (9adaafb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2255   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files         181      181           
  Lines       36287    36277   -10     
  Branches    22505    22496    -9     
=======================================
- Hits        24031    24026    -5     
- Misses       7674     7677    +3     
+ Partials     4582     4574    -8     
Flag Coverage Δ
svdconv-cov 40.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/svdconv/SVDModel/src/SvdTypes.cpp 44.82% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants