-
Notifications
You must be signed in to change notification settings - Fork 63
Update SMC2 entry and add SMC3 entry #2255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please also update EnumStringTables.h:
CPUTYPE(SMC3 , "SMC3" )
Please also update tools/svdconv/SVDModel/include/EnumStringTables.h for MC3, this is why we get the massice errors.
Test Results 6 files 12 suites 0s ⏱️ Results for commit 9adaafb. ♻️ This comment has been updated with latest results. |
thorstendb-ARM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
=======================================
Coverage 66.22% 66.22%
=======================================
Files 181 181
Lines 36287 36277 -10
Branches 22505 22496 -9
=======================================
- Hits 24031 24026 -5
- Misses 7674 7677 +3
+ Partials 4582 4574 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
No description provided.