Skip to content

Conversation

@grasci-arm
Copy link
Collaborator

  • Set Bname empty in RteTarget ProcessAttributes

  • Fix RPC tests

  • Remove ambiguity in XmlItem::SetAttributes()

by making two XmlItem constructors explicit

  • Make ubuntu C++ compiler happy

  • Try to fix the tests

  • Fix test data end test

  • Change one overload of SetAttributes to CopyAttributes

To satisfy compiler.

* Set Bname empty in RteTarget ProcessAttributes

* Fix RPC tests

* Remove ambiguity in XmlItem::SetAttributes()

by making two XmlItem constructors explicit

* Make ubuntu C++ compiler happy

* Try to fix the tests

* Fix test data end test

* Change one overload of SetAttributes to CopyAttributes

To satisfy compiler.
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Test Results

  7 files   53 suites   6m 12s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 8874e13.

♻️ This comment has been updated with latest results.

@edriouk edriouk merged commit d327733 into Open-CMSIS-Pack:main Nov 18, 2025
117 of 118 checks passed
@edriouk edriouk deleted the outbound/RteTargetBname branch November 18, 2025 06:48
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.22%. Comparing base (d2501c9) to head (8874e13).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrRpcTests.cpp 60.00% 0 Missing and 2 partials ⚠️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 50.00% 0 Missing and 1 partial ⚠️
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
- Coverage   66.22%   66.22%   -0.01%     
==========================================
  Files         181      181              
  Lines       36287    36287              
  Branches    22506    22505       -1     
==========================================
- Hits        24032    24031       -1     
+ Misses       7677     7674       -3     
- Partials     4578     4582       +4     
Flag Coverage Δ
buildmgr-cov 74.23% <ø> (ø)
packchk-cov 70.25% <ø> (ø)
packgen-cov 77.55% <ø> (ø)
projmgr-cov 80.30% <60.00%> (-0.01%) ⬇️
svdconv-cov 40.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgr.cpp 80.15% <100.00%> (ø)
tools/projmgr/test/src/ProjMgrUnitTests.cpp 79.12% <50.00%> (ø)
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp 65.53% <0.00%> (ø)
tools/projmgr/test/src/ProjMgrRpcTests.cpp 55.27% <60.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants