Merged
Conversation
dlamoris
requested changes
Feb 18, 2021
| } | ||
|
|
||
| public void clear() { | ||
| if (allRequests.size() > bulkLimit) { |
| } | ||
|
|
||
| public void close() { | ||
| batches(allRequests, bulkLimit).forEach(this::bulkBatchRequests); |
Collaborator
There was a problem hiding this comment.
do you still need to batch? since adds always clear it when it reaches the limit anything left shouldn't go above the limit
| protected int bulkLimit; | ||
| RestHighLevelClient client; | ||
| RequestOptions options; | ||
| List<DocWriteRequest<?>> allRequests = new ArrayList<>(); |
Collaborator
There was a problem hiding this comment.
this can just be BulkRequest, then bulkBatchRequests don't need to readd them all when sending
| BulkRequest bulkRequest = new BulkRequest(); | ||
| actionRequest.forEach(bulkRequest::add); | ||
| try { | ||
| client.bulk(bulkRequest, options); |
Collaborator
There was a problem hiding this comment.
need to check result for failures and throw stuff
dlamoris
approved these changes
Feb 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.