add checks for 500 and 409 errors, use sha-1 as suffix for branches with id > 50#155
Merged
add checks for 500 and 409 errors, use sha-1 as suffix for branches with id > 50#155
Conversation
HuiJun
approved these changes
Feb 23, 2021
dlamoris
changed the title
HuiJun
approved these changes
Feb 24, 2021
Collaborator
HuiJun
left a comment
HuiJun
left a comment
There was a problem hiding this comment.
Small note, maybe we should name getSuffix something more appropriate now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.