Skip to content

Feature/cores whitelist#193

Merged
HuiJun merged 9 commits intoOpen-MBEE:developfrom
Enquier:feature/coresWhitelist
Aug 22, 2022
Merged

Feature/cores whitelist#193
HuiJun merged 9 commits intoOpen-MBEE:developfrom
Enquier:feature/coresWhitelist

Conversation

@Enquier
Copy link
Contributor

@Enquier Enquier commented Jun 29, 2022

minor feature to allow users to specify a comma separated list of AllowedOrigins for CORS. This is important because certain browsers reject requests that allow * and allow credentials. Default is to existing functionality of "*"

@HuiJun
Copy link
Collaborator

HuiJun commented Aug 9, 2022

We generally leave CORS configuration to the implementation. For instance, in our Reference Implementation here

@HuiJun
Copy link
Collaborator

HuiJun commented Aug 9, 2022

Closing in favor of Open-MBEE/exec-mmsri#47

@HuiJun HuiJun closed this Aug 9, 2022
@Enquier Enquier reopened this Aug 22, 2022
@Enquier
Copy link
Contributor Author

Enquier commented Aug 22, 2022

This should be in MMS as well as MMSRI Reopening

@HuiJun HuiJun merged commit 598f52d into Open-MBEE:develop Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants