fix: support users and groups in distinct DN bases#195
Merged
Conversation
HuiJun
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #194
The important changes are:
userData.getDn()instead ofuserAttributesUsername + '=' + usernameto get the entire DN, e.g. ifldap.user.dn.pattern=uid={0},ou=usersthis will resolve touid=billy,ou=usersinstead of justuid=billygroupSearchBasefor the group LDAP searchThis change should be fully backwards compatible, i.e. should not require any configuration change for currently functioning deployments. It will add support for LDAP structures (currently incompatible) as described in #194 using a configuration like the following: