Skip to content

return element json if artifact mime type not found#200

Merged
HuiJun merged 1 commit intodevelopfrom
feature/support-browser-element-link
Sep 15, 2022
Merged

return element json if artifact mime type not found#200
HuiJun merged 1 commit intodevelopfrom
feature/support-browser-element-link

Conversation

@dlamoris
Copy link
Collaborator

because of content negotiation, the get element endpoint goes to artifact controller if accept header is anything other than application/json or empty, browsers put stuff incompatible stuff in there, this is so a browser link returns something useful besides artifact not found

@dlamoris dlamoris requested a review from HuiJun September 14, 2022 18:17
Copy link
Collaborator

@HuiJun HuiJun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuiJun HuiJun merged commit e9ad12f into develop Sep 15, 2022
@HuiJun HuiJun deleted the feature/support-browser-element-link branch September 15, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants