Adding new bulk processor for elasticsearch implementation#95
Merged
Adding new bulk processor for elasticsearch implementation#95
Conversation
dlamoris
requested changes
Sep 16, 2020
gradle.properties
Outdated
| jacksonVersion=2.10.3 | ||
| log4jVersion=2.13.1 | ||
| elasticVersion=7.1.1 | ||
| elasticVersion=7.9.0 |
Collaborator
There was a problem hiding this comment.
is there a 7.7.x version? the highest on aws right now is 7.7 and the client are forward but not backwards compatible
| public CommitsResponse updateTwcRevisionID(String projectId, String commitId, String revisionId) { | ||
| CommitsResponse commitsResponse = new CommitsResponse(); | ||
| if (revisionId.isEmpty() || revisionId.isBlank()) { | ||
| if (revisionId.isEmpty()) { |
Collaborator
There was a problem hiding this comment.
should check for null first also
| } | ||
|
|
||
| @Override | ||
| public void afterBulk(long executionId, BulkRequest request, BulkResponse response) { |
Collaborator
There was a problem hiding this comment.
should log any failures for now
|
|
||
| public abstract class BaseElasticDAOImpl<E extends Map<String, Object>> { | ||
|
|
||
| private final Logger logger = LogManager.getLogger(getClass()); |
Collaborator
There was a problem hiding this comment.
use slf4j LoggerFactory.getLogger(getClass())
| project(':jupyter'), | ||
| project(':permissions'), | ||
| project(':webhooks'), | ||
| project(':twc'), |
dlamoris
reviewed
Sep 18, 2020
| public CommitsResponse updateTwcRevisionID(String projectId, String commitId, String revisionId) { | ||
| CommitsResponse commitsResponse = new CommitsResponse(); | ||
| if (revisionId.isEmpty() || revisionId.isBlank()) { | ||
| if (revisionId != null && revisionId.isEmpty()) { |
dlamoris
approved these changes
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.