T8 #1618
Merged
T8 #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling and class instantiation
…hod for better type safety
- Updated AFCmdBase, AFCmdOS, CSV, SimpleLog, and various plugins to use Function instead of NativeFunction for better compatibility with the latest Rhino JavaScript engine. - Adjusted method signatures in HTTP, HTTPServer, JMXServer, SNMPServer, and Threads to reflect the change in function type. - Ensured consistent usage of Function across all relevant classes to streamline the codebase and improve maintainability.
…an up unused code
Sync t8 to t9
…ve script execution context
… resources in AFCmdOS
…, and enhance OAFdCL classloader cache pre-warming
…for better compatibility and readability
…dClasses function
…Compiler to optimize class file size
…s and backward compatibility
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces Agent-to-Agent (A2A) messaging capabilities over MCP (Model Context Protocol), enhances Gemini AI integration with improved stats tracking and function call handling, and performs maintenance tasks including dependency updates and removal of obsolete shell completion scripts.
Changes:
- Added A2A agent registry and messaging infrastructure with MCP integration, including agent management endpoints and client methods
- Enhanced Gemini AI integration with improved token stats tracking, system instruction handling, and function call response normalization
- Updated multiple Java and JavaScript dependencies and removed legacy shell completion scripts
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| js/owrap.server.js | Adds A2A registry class with agent management, rate limiting, authentication, and MCP protocol integration |
| js/openaf.js | Implements $mcp client methods for A2A agent interactions (listAgents, getAgent, sendToAgent) |
| js/owrap.ai.js | Enhances Gemini stats extraction, improves function call response handling, adds ow.ai.agent helper, and refactors decision tree predicates |
| src/openaf/AFCmdBase.java | Updates version, replaces NativeFunction with Function interface, adds static block for logging config, and simplifies SimpleLog initialization |
| tests/autoTestAll.A2A.yaml | Adds comprehensive test suite for A2A functionality |
| tests/autoTestAll.A2A.js | Implements test functions for A2A registry, server, client, messaging, auth, size limits, and rate limits |
| pom.json | Updates multiple dependencies including Rhino, Apache Commons, Jetty, OkHttp, Okio, jsch, and snmp4j-agent |
| complete/*.sh | Removes obsolete shell completion scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Fix indentation of _captureStats function in owrap.ai.js
github-project-automation
bot
moved this from Backlog
to Done
in Continuous Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features related to agent handling in the MCP client and enhances the Gemini AI integration. The most significant changes are the addition of agent management functions to
$mcp, improved handling of Gemini API responses and prompts, and some code quality improvements.MCP Agent Management Enhancements
$mcp, including JSON-RPC endpoints for listing, retrieving, and sending messages to agents (agents/list,agents/get,agents/send). These stubs support basic agent metadata and message handling, including error responses and handler functions.$mcpclient methods:listAgents,getAgent, andsendToAgent, each with documentation and error handling to interact with A2A agents via MCP. These methods require initialization and support hooks for pre/post-processing.Gemini AI Integration Improvements
modelVersion,responseId, and additional token usage fields (cachedContentTokenCount,thoughtsTokenCount) in the stats map for better tracking and reporting.partsandcontentfields.Code Quality Improvements
Removal of Legacy Shell Completion Scripts
openafandopack, cleaning up unused code from the repository. (complete/completion_oaf.sh,complete/completion_opack.sh)