[BUG][Go] path parameter values should be urlencoded

[kraney]

Description

When .a path / method includes a path parameter, the generated Go client accepts the value and injects it into the path unchanged. If the value contains URL-significant characters, like a '/', this will cause unexpected behavior.

openapi-generator version

4.1.0-SNAPSHOT

OpenAPI declaration file content or url

  /filters/{filters_identifier}:
    delete:
      description: Remove a filter from the system.
      parameters:
      - in: path
        name: filters_identifier
        required: true
        schema:
          type: string

Command line used for generation

docker run --name oas --rm -v ${PWD}:/local openapi-generator generated -g go-experimental ...

Steps to reproduce

Call the path above with parameter filters_identifier = "foo/bar"

Suggest a fix

Always urlencode path parameters

[wing328]

@kraney thanks for reporting the issue. May I know if you've time to contribute a fix?

[kraney]

I can try to take a look. I can't make any promises because I'm only familiar with the generator as a user of it, not as a developer. It's one thing to look at the code it produces and recognize an issue, and another to understand how that code came to be generated.

[wing328]

OK. Just PM me via Slack if you need help: https://join.slack.com/t/openapi-generator/shared_invite/enQtNzAyNDMyOTU0OTE1LTY5ZDBiNDI5NzI5ZjQ1Y2E5OWVjMjZkYzY1ZGM2MWQ4YWFjMzcyNDY5MGI4NjQxNDBiMTlmZTc5NjY2ZTQ5MGM