[BUG] v4.3.1 - COLLECTION_FORMATS.pipe is used but does not exist but pipes exist

[nrail-joerg-walter]

call:

openapi-generator generate -i x.yaml -g typescript-axios -o ./src

[macjohnny]

@nrail-joerg-walter would you like to fix this?

[nrail-joerg-walter]

@nrail-joerg-walter would you like to fix this?

What is the offending repo and what is the intended behaviour?

[macjohnny]

I think this should be changed here

openapi-generator/modules/openapi-generator/src/main/resources/typescript-axios/baseApi.mustache

Lines 16 to 21 in b7b0090

	export const COLLECTION_FORMATS = {
	csv: ",",
	ssv: " ",
	tsv: "\t",
	pipes: "|",
	};

this is related to #6553

It should be pipe instead of pipes

[joerg-walter-de]

It seems to me that pipes is the dominant usage in the repo. This definition of COLLECTION_FORMATS appears in many files. And from the conversation (#4999) it seems to me that I should be pipes.

[macjohnny]

@jimschubert can you help here?

[jimschubert]

This would be a problem with the spec document itself, I think, but it's hard to say without a sample document. There is no collectionFormat pipe.

In OpenAPI 3.x, there's style pipeDelimited.

In OpenAPI 2.0, there's collectionFormat pipes.

Really, I would think swagger-parser should fail validation if there's an invalid collectionFormat.

The options in the image look like they match the OpenAPI 2.0 specification, so it should really be pipes. If it's a 3.0 document, then we would want to convert pipe to pipes in the generator.

[jimschubert]

Dug in more, the issue is that 4.3.1 incorrectly set this as pipe and this is already fixed.

Please target 5.0.0-beta and let us know how it goes.

[jimschubert]

As a workaround for 4.3.1 if 5.0.0-beta is not possible, you can download 4.3.1's baseApi.mustache to some directory such as template-fix, edit from pipes to pipe, then generate targeting the customized template:

openapi-generator generate -i x.yaml -g typescript-axios -o ./src -t /path/to/template-fix