[BUG] Java oneof Classes are not generated

[neopaf]

Description

(Thanks for fantastic tool!)

I expect OneOfGeographicLocationGeographicLocationRef.java be created.

Actual: no such file is generated

openapi-generator version

Tried with

• 4.3.1
• openapi-generator-cli-5.0.0-20200813.162255-527.jar

OpenAPI declaration file content or url

Swagger.json.txt

Generation Details

openapi-generator  generate -I Swagger.json.txt -g jaxrs-cxf-client 

Steps to reproduce

Run above command, you'll get
src/gen/java/org/openapitools/model/GeographicLocation.java
which contains

import org.openapitools.model.OneOfGeographicLocationGeographicLocationRef;

But no such class was generated.

[kito99]

Just ran into this as well with the same version. Can we get this prioritized for the next release?

[neopaf]

@kito99 Kito, my sympathy...
For now I've just handmade missing files... just so I could still use generated code.
But I'm not happy :(

[wing328]

Please try the java (library: jersey2) client generator in the latest master, which offers better support for oneOf, anyOf.

[sarumont]

I observe the same on beta2 (which should have the changes @wing328 mentioned) with generate -i ../app/api.yml -g java --library jersey2.

Edit 0: Looks like SchemaSupportFeature.Union isn't supported by any Java generator, and this is the feature that seems to support oneOf (from my brief scanning here).

Edit 1: It's possibly deeper than that...enabling both Union and Polymorphism in JavaClientCodegen.java yields the same results for me.

[seybi87]

@kito99 Kito, my sympathy...
For now I've just handmade missing files... just so I could still use generated code.
But I'm not happy :(

@neopaf I am also facing this issue :-(

As you have resolved these problems by manually creating the required classes, do you have a MWE example with the created classes online?
This would be much appreciated 👍

[neopaf]

I did just a trivial hack, not something that works as client/server.

I need code for investigation purposes only...

[sarumont]

@seybi87 I just got back to this today and need a compiling JAR. I think this will work (about to test it, and I'll report back here):

package com.devsupply.dana.model;

import java.util.Objects;
import com.fasterxml.jackson.annotation.JsonProperty;

/**
 * OrgAllOf
 */
public class OneOfUserApiKey {
  private User user;
  private ApiKey apiKey;

  public void setUser(User user) {
    user(user);
  }

  public void setApiKey(ApiKey apiKey) {
    apiKey(apiKey);
  }

  public OneOfUserApiKey user(User user) {
    this.user = user;
    this.apiKey = null;
    return this;
  }

  public OneOfUserApiKey apiKey(ApiKey apiKey) {
    this.user = null;
    this.apiKey = apiKey;
    return this;
  }

  @javax.annotation.Nullable
  @JsonProperty("apiKey")
  public ApiKey getApiKey() {
    return this.apiKey;
  }

  @javax.annotation.Nullable
  @JsonProperty("user")
  public User getUser() {
    return this.user;
  }

  /**
   * Return true if this Org_allOf object is equal to o.
   */
  @Override
  public boolean equals(Object o) {
    if (this == o) {
      return true;
    }
    if (o == null || getClass() != o.getClass()) {
      return false;
    }
    OneOfUserApiKey other = (OneOfUserApiKey) o;
    return Objects.equals(this.user, other.user) &&
        Objects.equals(this.apiKey, other.apiKey);
  }

  @Override
  public int hashCode() {
    return Objects.hash(user, apiKey);
  }


  @Override
  public String toString() {
    StringBuilder sb = new StringBuilder();
    sb.append("class OneOfUserApiKey {\n");
    sb.append("    user: ").append(toIndentedString(user)).append("\n");
    sb.append("    apiKey: ").append(toIndentedString(apiKey)).append("\n");
    sb.append("}");
    return sb.toString();
  }

  /**
   * Convert the given object to string with each line indented by 4 spaces
   * (except the first line).
   */
  private String toIndentedString(Object o) {
    if (o == null) {
      return "null";
    }
    return o.toString().replace("\n", "\n    ");
  }

}

Deserialization would have non-deterministic behavior if both apiKey and user were present in the JSON document, though. Not sure how to handle that for a proper PR here. I suppose a JsonDeserializer would have access to the entire tree at the time of deserialization, so it could throw. Thoughts on that part @wing328 ?

[IvanVas]

It's still persists and a real pain.

[wing328]

java (library: jersey2, native, okhttp-gson) has better support of oneOf and anyOf.

We welcome contributions to plot the implementation to other java clients (jaxrs-cxf-client)