[BUG][csharp] [csharp-netcore] producing invalid Dictionary

[InTheCloudDan]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

openapi-generator version

5.1.1
and
5.2.0-20210607.065944-108

OpenAPI declaration file content or url

Generation Details

Steps to reproduce

      "example": {
        "type": "object",
        "additionalProperties": true
      }

or additionalProperties: {}

Create a spec with the model above and use csharp or csharp-netcore to generate a client. It errors with error CS0305: Using the generic type 'Dictionary<TKey, TValue>' requires 2 type arguments

The property in code shows as Dictionary without any additional type information

[prajon84]

Thanks @InTheCloudDan . I also recently got stumbled in the similar issue.
When openapi.yaml consists of:

components:
  schemas:
    Activity:
      description: 
      type: object
      properties:
        activity_outputs:
          type: object
          additionalProperties:
            $ref: '#/components/schemas/ActivityOutputRepresentation'
    ActivityOutputRepresentation:
      type: array
      items: 
        $ref: '#/components/schemas/ActivityOutputElementRepresentation'
    ActivityOutputElementRepresentation:
      type: object
      properties:
        prop1:
          type: string
        prop2:
          type: object

I get the error as:

[InTheCloudDan]

The one I'm running into seems like it originating from here: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/csharp/modelGeneric.mustache#L113

But with the same root cause, I found one that was also a List not just Dictionary

[prajon84]

@InTheCloudDan : Did you find any fix for this yet?

[InTheCloudDan]

@prajon84 no, we have not made any progress on this issue yet.

[prajon84]

@prajon84 no, we have not made any progress on this issue yet.

Oh Ok. Thank you for the update on your side.

[prajon84]

@wing328 @Blackclaws @shibayan @lucamazzanti @devhl-labs any idea to resolve this ?

[Blackclaws]

Yeah ok, that is a weird issue. Additional properties in general are a bit of a mixed bag. We're just throwing the bunch of them into a dictionary that should be string, object. I have no clue why it generates a List object type here or a dictionary without any types whatsoever. I'll take a look after the holiday season is over.

[dietermijle]

Any progress on this one? We're experiencing the same issue...

[prajon84]

Hello @Blackclaws, any idea how to resolve this?