Various fixes by wing328 · Pull Request #1 · OpenAPITools/openapi-generator

wing328 · 2018-05-12T11:39:52Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Various fixes reported by the CI.

jimschubert · 2018-05-12T12:27:48Z

pom.xml

                <module>samples/client/petstore/groovy</module>
                <module>samples/client/petstore/rust</module>
-                <module>samples/client/petstore/perl</module>
+                <!--<module>samples/client/petstore/perl</module>-->


Should this pom match the circlci poms? The go client is commented there and perl is commented here.

Good question but they should not be the same as different CIs should test different clients/servers.

wing328 · 2018-05-12T16:03:20Z

The issues reported by CircleCI will be handled in another PR.

* Make SwaggerCodeGen serialize subclasses properly (PHNX-859) (#1) Motivation ---- Previously, when serializing as subclass of a property, generated swagger clients would only serialize properties of the parent class causing some values to not be pass through Modifications ---- Before serializing attributes of a given type, we check to see if there is a specific type to be serialized so that we don't miss any properties. * Fix improper whitespace in mustache template (PHNX-859) (#2) Motivation ---- OpenAPI Generator upstream requested whitespace fixes (from tabs to 4 spaces) Modifications ---- Fixed whitespace

* Kotlin Spring initial bootstrap * Basic configuration construction for Kotlin Spring * Wired up with comand line client * Initial kotlin spring boot application generated using gradle kotlin-dsl * Added basic support for generating models * Basic controllers generated without endpoints generated * Basic spring boot app generated with models and controllers * Added fix for type mapping in AbstractKotlinCodegen. Originally it was mapping list o kotlin.Array instead of kotlin.collections.List * Fixed return type mapping * Sorted bash springboot petstore generator script * Implemented toVarName in AbstractKotlinCodegen to better handle some edgecases * Checking for reserved words or numerical starting class names in AbstractKotlinCodegen * Implemented toOperationId in AbstractKotlinCodegen * Fixed types that were not correctly being mapped to primitives (byte / arrayOf / mapOf) * Escaping dollar symbols in function names * Added support for outter enum classes * Added basic support for generating services * Removed option for generated config package. Added option to enable/disable generated global exception handler * Added configuration option to generate gradle. Generated maven pom.xml file as default * Fixed up bash scripts for generating test sample code * Added configurable option for Swagger Annotations * Added configurable option for generating service interfaces and service implementations * Added README generation * Enable optional bean validation * Added kotlin spring sample to CircleCI pom.xml * Removed kotlin spring boot from .gitignore * Minor fixes from PR comments for user submission (#1) * Minor fixes from PR comments for user submission * Puts braces around conditional block bodies with one-liner bodies. * Modifies README.mustache to use artifact id and version supplied by user (or default configuration) * Targets templates under resource directory explicitly to prevent the need to rebuild for evaluation of template-only changes. * [kotlin-spring] Remove comments referencing sbt in bash scripts * List of changes based upon code review: * Additional comments around how we set the title based off the open api spec * Fixed missing `beanValidationCore` template * Put the lambdas into the lambda object as other generators do (Ktor, C#, cpp) * Bump swagger-annotations version to latest pre-2.0 version (1.5.21) * Set kotlin version to 1.2.60 * Updated README to set port based on template * Added more additional properties to build bash scripts * Removed `defaultBasePath.mustache` in place of using {{contextPath}} directly * Log warning for when `serviceImplementation` is set t o true * Updated samples * Generating ConstraintViolation Exception Handler, as Springboot doesnt correctly catch the error and return bad request. Handling other exceptions a litle better * Small fix for date time mappings (plus sample re-gen) * Minor fix in README template, where port was using wrong variable * Fix missing jackson-dataformat-xml dependency * Fix build - needed to re-run kotlin-server-petstore.sh * Fixes after merge with master * Revert "Small fix for date time mappings (plus sample re-gen)" This reverts commit 4152dc78b4813da71c675272ca90fb31a333aea1. * Moved type mappings to Kotlin Spring generator * Regenerated samples * Regenerated samples

Bring my fork up to date with base

* Kotlin Spring initial bootstrap * Basic configuration construction for Kotlin Spring * Wired up with comand line client * Initial kotlin spring boot application generated using gradle kotlin-dsl * Added basic support for generating models * Basic controllers generated without endpoints generated * Basic spring boot app generated with models and controllers * Added fix for type mapping in AbstractKotlinCodegen. Originally it was mapping list o kotlin.Array instead of kotlin.collections.List * Fixed return type mapping * Sorted bash springboot petstore generator script * Implemented toVarName in AbstractKotlinCodegen to better handle some edgecases * Checking for reserved words or numerical starting class names in AbstractKotlinCodegen * Implemented toOperationId in AbstractKotlinCodegen * Fixed types that were not correctly being mapped to primitives (byte / arrayOf / mapOf) * Escaping dollar symbols in function names * Added support for outter enum classes * Added basic support for generating services * Removed option for generated config package. Added option to enable/disable generated global exception handler * Added configuration option to generate gradle. Generated maven pom.xml file as default * Fixed up bash scripts for generating test sample code * Added configurable option for Swagger Annotations * Added configurable option for generating service interfaces and service implementations * Added README generation * Enable optional bean validation * Added kotlin spring sample to CircleCI pom.xml * Removed kotlin spring boot from .gitignore * Minor fixes from PR comments for user submission (#1) * Minor fixes from PR comments for user submission * Puts braces around conditional block bodies with one-liner bodies. * Modifies README.mustache to use artifact id and version supplied by user (or default configuration) * Targets templates under resource directory explicitly to prevent the need to rebuild for evaluation of template-only changes. * [kotlin-spring] Remove comments referencing sbt in bash scripts * List of changes based upon code review: * Additional comments around how we set the title based off the open api spec * Fixed missing `beanValidationCore` template * Put the lambdas into the lambda object as other generators do (Ktor, C#, cpp) * Bump swagger-annotations version to latest pre-2.0 version (1.5.21) * Set kotlin version to 1.2.60 * Updated README to set port based on template * Added more additional properties to build bash scripts * Removed `defaultBasePath.mustache` in place of using {{contextPath}} directly * Log warning for when `serviceImplementation` is set t o true * Updated samples * Generating ConstraintViolation Exception Handler, as Springboot doesnt correctly catch the error and return bad request. Handling other exceptions a litle better * Small fix for date time mappings (plus sample re-gen) * Minor fix in README template, where port was using wrong variable * Fix missing jackson-dataformat-xml dependency * Fix build - needed to re-run kotlin-server-petstore.sh * Fixes after merge with master * Revert "Small fix for date time mappings (plus sample re-gen)" This reverts commit 4152dc78b4813da71c675272ca90fb31a333aea1. * Moved type mappings to Kotlin Spring generator * Regenerated samples * Regenerated samples

* Create JavaMicroprofile generator * Add ApiException and ApiExeptionMapper * Add documentation for running the generator * Update README * Capitalize P in MicroProfile * Clean up generated model for microprofile rest client * Revert change in AbstractJavaCodegen and move the action into JavaMicroprofile * Remove non-cxf templates in JavaMicroprofile and rename cxf to mp" * Remove mp/server files * Update pom.xml to have MpRestClient dependencies * Generate tests using smallrye implementation * Change JavaMicroprofile.java to JavaMicroprofileCodegen.java * Add test for JavaMicroprofileCodegen * Add scripts to generate petstore sample * Add README * Revert "Add scripts to generate petstore sample" This reverts commit 25ee496. * Revert "Add README" This reverts commit 067b2a8. * Revert "Revert "Add scripts to generate petstore sample"" This reverts commit 5a36390. * Add README * Move templates out of mp/ directory * Remove CXF references * Remove unnecessary templates * Fix compilation errors * Add missing jsonb dependency * Add license header to code templates * Increase copyright year to 2019 * Remove TODO comments and commented out code * Add more javadocs to the model templates * Fix issues with generated code * Revert README back to master's README * Add documentation for java microprofile client generator * Add MicroProfile Rest Client to list of clients in README * Remove smartbear copyright from java files * Add disableMultipart option * Fix licenseInfo * Rename JavaMicroprofileCodegen to JavaMicroprofileRestClientCodegen * Rename sample scripts to java-microprofile-rest-client * Adjust test comments * Better spacing between members for generated models * Update getHelp() method * Update javadoc for tests

retrigger build OpenAPITools#1

Merge master

Upgrade to kotlin 1.4 & bug fixes for kotlin MPP

Merge from Egeniq repository

Pulling from source

…ls#1)

merge upstream

Sync with latest openapi master

Nice thank you!

update master

Configure Renovate

Fix for generated files

…xios (#1…" This reverts commit 8152052.

…xios (#1…" (#18452) This reverts commit 8152052.

fix. Default string values now with "quotes"

Scala sttp4 jsoniter wip

…#22390)

…streaming (#22673) * Update isomorphic-fetch file to allow for response streaming (#1) * Update samples/openapi3/client/petstore/typescript/builds/inversify/http/http.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update samples/client/echo_api/typescript/build/http/http.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update samples/openapi3/client/petstore/typescript/builds/object_params/http/http.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update samples * fix tests --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

wing328 added 7 commits May 12, 2018 19:09

fix pistache c++ server in windows

cb6b1a2

skip perl test

124d274

comment out go tests

ea6808f

Fix go test, manually fix go client

1b01698

fix rails batch file

9cbe543

fix tab in java file

dabf9db

install rust

2afb01e

wing328 added this to the 3.0.0 milestone May 12, 2018

jimschubert approved these changes May 12, 2018

View reviewed changes

wing328 added 7 commits May 12, 2018 21:37

fix swift2-deprecated in windows batch file

7f1aafa

fix rust installation

3979bf1

comment out js test

c117252

update swift windows batch files

35e3a5d

update tizen batch script

ede0ad5

comment out ktor test

9e4b576

Merge branch 'master' into first_fix

68f18c7

wing328 merged commit 1d889da into master May 12, 2018

wing328 deleted the first_fix branch May 12, 2018 17:58

gbrown-ce mentioned this pull request May 18, 2018

[Typescript-Node] Incorrect serialization of subclasses in generated code #100

Closed

thomasphansen mentioned this pull request Jun 25, 2018

Fix #352 - [PHP] [Improvement] Make Api return object instead of array #353

Closed

4 tasks

mmunz-nextdoor mentioned this pull request Oct 23, 2018

[Python] Support for package hierarchy #1302

Open

wing328 pushed a commit that referenced this pull request Jan 25, 2019

Merge pull request #1 from OpenAPITools/master

a270b98

Bring my fork up to date with base

krystalmonolith mentioned this pull request Nov 27, 2019

[BUG] Cannot suppress "[WARNING] Output directory does not exist, or is inaccessible. No file (.openapi-generator-ignore) will be evaluated." message. #4627

Closed

spacether mentioned this pull request May 14, 2020

[codegen][python-experimental] Composed schema with additionalProperties #6290

Merged

5 tasks

arvindth mentioned this pull request May 22, 2020

[Go] Interface definitions for api functions #5914

Merged

5 tasks

sebastien-rosset mentioned this pull request Jul 16, 2020

[BUG][Java][jersey2] Incorrect serialization of HTTP GET request body #6954

Closed

6 tasks

nielspardon added a commit to nielspardon/openapi-generator that referenced this pull request Jul 24, 2020

Updated samples

1068ce5

retrigger build OpenAPITools#1

wing328 pushed a commit that referenced this pull request Sep 28, 2020

Merge pull request #1 from OpenAPITools/master

484cd19

Merge master

Thecrazyskull pushed a commit to Thecrazyskull/openapi-generator that referenced this pull request Nov 13, 2020

Merge pull request OpenAPITools#1 from Thecrazyskull/master

d9e8717

Upgrade to kotlin 1.4 & bug fixes for kotlin MPP

Thecrazyskull pushed a commit to Thecrazyskull/openapi-generator that referenced this pull request Nov 13, 2020

Merge pull request OpenAPITools#1 from egeniq/master

b07620d

Merge from Egeniq repository

wing328 pushed a commit that referenced this pull request Jan 5, 2021

Merge pull request #1 from OpenAPITools/master

8cf9ddb

Pulling from source

jon-v mentioned this pull request Jan 8, 2021

[BUG] [typescript-angular] AllOf hierarchy produces api that doesn't compile #8000

Closed

christiancompton pushed a commit to christiancompton/openapi-generator that referenced this pull request Apr 27, 2021

fix: Dont add array imports for map containter properties (OpenAPIToo…

fb6aae6

…ls#1)

wing328 pushed a commit that referenced this pull request Jun 9, 2021

Merge pull request #1 from OpenAPITools/master

d71105a

merge upstream

mariodsantana mentioned this pull request Nov 9, 2021

[BUG][PYTHON] BOUNTY Unwanted string-to-date coercion in allOf #10812

Closed

6 tasks

wing328 pushed a commit that referenced this pull request Jan 2, 2022

Merge pull request #1 from OpenAPITools/master

7b42777

Sync with latest openapi master

wing328 pushed a commit that referenced this pull request May 23, 2022

Merge pull request #1 from renaud-twd/6.0.x-symfony6

4241833

Nice thank you!

hanakslr pushed a commit to hanakslr/openapi-generator that referenced this pull request May 27, 2022

Merge pull request OpenAPITools#1 from OpenAPITools/master

5b9e72a

update master

This was referenced Dec 8, 2022

Crash Observed for JSON Conversion of Enum value #14219

Open

Crash happened for attribute of type integer with value 0 in REST C Client code generated by OpenApiTool #14224

Open

nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023

Merge pull request OpenAPITools#1 from HarmoWatch/renovate/configure

90044ac

Configure Renovate

wing328 pushed a commit that referenced this pull request Jan 29, 2024

Merge pull request #1 from aronkankel/master

ef94ee7

Fix for generated files

JFCote mentioned this pull request Feb 29, 2024

[BUG] Double nullable operator ("??") when combining "nullable" and "not required" field in body model #18005

Closed

5 tasks

macjohnny added a commit that referenced this pull request Apr 22, 2024

Revert "Fix: Incorrect serialisation of maps and sets in typescript-a…

3a1e170

…xios (#1…" This reverts commit 8152052.

macjohnny added a commit that referenced this pull request Apr 22, 2024

Revert "Fix: Incorrect serialisation of maps and sets in typescript-a…

36911c7

…xios (#1…" (#18452) This reverts commit 8152052.

jath03 mentioned this pull request Jun 20, 2024

[BUG][RUST] oneOf with value and array results in invalid code #18984

Open

6 tasks

fire pushed a commit to V-Sekai/openapi-generator that referenced this pull request Jun 25, 2024

Merge pull request OpenAPITools#1 from saatsazov/feat-gdscript

13d3c5c

fix. Default string values now with "quotes"

gcatanese mentioned this pull request Oct 2, 2024

[Typescript-Node] Mark deprecated model attributes #19756

Merged

5 tasks

stollr mentioned this pull request Feb 12, 2025

[BUG][PHP][PSR18] Invalid client generation when request body is json or xml #20646

Open

6 tasks

wing328 pushed a commit that referenced this pull request Sep 6, 2025

Merge pull request #1 from lbialy/scala-sttp4-jsoniter-wip

1a630aa

Scala sttp4 jsoniter wip

wing328 pushed a commit that referenced this pull request Dec 17, 2025

fix: missing imports for array of files and date-time parameters (#1) (…

e1edb9e

…#22390)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Various fixes#1

Various fixes#1
wing328 merged 14 commits intomasterfrom
first_fix

wing328 commented May 12, 2018

Uh oh!

jimschubert May 12, 2018

Uh oh!

wing328 May 12, 2018

Uh oh!

wing328 commented May 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wing328 commented May 12, 2018

PR checklist

Description of the PR

Uh oh!

jimschubert May 12, 2018

Choose a reason for hiding this comment

Uh oh!

wing328 May 12, 2018

Choose a reason for hiding this comment

Uh oh!

wing328 commented May 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants