PR for openapi-generator-maven-plugin inputSpec -- Allow jar: URLs#10037
PR for openapi-generator-maven-plugin inputSpec -- Allow jar: URLs#10037allen-ball wants to merge 17 commits intoOpenAPITools:masterfrom
Conversation
E.g., jar:jar-specific-uri!/spec.yml.
specifications: * URLs of the form jar:jar-specific-uri!/spec.yaml * Resources on the compilation classpath in addition to the existing FILE test case.
allen-ball
changed the title
| <swagger-core-version>2.1.2</swagger-core-version> | ||
| <swagger-parser-groupid>io.swagger.parser.v3</swagger-parser-groupid> | ||
| <swagger-parser-version>2.0.26</swagger-parser-version> | ||
| <swagger-parser-version>2.0.28-SNAPSHOT</swagger-parser-version> |
There was a problem hiding this comment.
I think we will need to wait for the 2.0.28 release before merging this enhancement.
There was a problem hiding this comment.
It seems that 2.1.12 has already been released
|
@allen-ball Are you looking to fix the merge conflicts on this MR so it can be be ready to merge ? The dependency spring-parser version is now released. |
|
@allen-ball are you planning to merge this?? |
|
I would also like this feature to be available as fast as is reasonable. |
|
When are we planning to merge this ? This is much needed. |
|
@jimschubert Can we support you somehow? This is a top 10 feature, needed very much. Being able to take the spec from classpath would ease the setup of a project as well as sharing specs and lead to an better build structure. |
|
@allen-ball is there any chance you will work on this PR? |
|
Please go ahead and do so — I haven’t been able to find the time to follow up on this.
Thanks!
— Allen
… On May 4, 2024, at 3:08 PM, Paul Parenko ***@***.***> wrote:
@allen-ball <https://github.com/allen-ball> is the any chance you will work on this PR?
If not, I've rebased your branch on master <https://github.com/parenko/openapi-generator/tree/fix-10016>, fixed merge conflicts, removed swagger-parser 2.0.28-SNAPSHOT since openapi-generator uses 2.1.19 <https://github.com/OpenAPITools/openapi-generator/blob/master/pom.xml#L1255> now, and could create a PR.
—
Reply to this email directly, view it on GitHub <#10037 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMXB7XYH5B47E7WFXOGGMGTZAVL7RAVCNFSM5A62VAWKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBZGQ2DINBXGE2Q>.
You are receiving this because you were mentioned.
|
|
closed via #18576 |
8 participants
This is a PR in response to #10016. It changes
<inputSpec/>processing to:In the case that a compilation classpath resource is specified, the resource URL is passed to the swagger-parser OpenAPIV3Parser instead of the
<inputSpec/>string since the OpenAPIV3Parser does not have access to the Maven compilation classpath. This requires swagger-api/swagger-parser#1592 and swagger-api/swagger-parser#1593.modules/openapi-generator-maven-plugin/src/test/java/org/openapitools/codegen/plugin/CodeGenMojoTest.java has been expanded to include tests for resource and URL input specs.