[Kotlin][Multiplatform] Add missing JVM dependency#10051
Conversation
This dependency was accidentally removed in PR OpenAPITools#9755 where we switched from `build.gradle` to `build.gradle.kts`.
|
Actually comparing the two files, it seems that there are a lot of missing dependencies. |
|
@4brunu good point. However I have a possibility to test only the JVM target in the multiplatform project, hence I'm limiting the changes to what I can test. It's the most popular target, so IMO it still make sense to make this simple change and tackle others later. |
|
Could you please add the remaining one's without testing? |
|
I checked the dependencies and in fact nothing more seems to be missing. One may think that e.g. |
|
@837 @DevSrSouza could you please help to review this PR? |
|
Looks good to me, seems like I really just missed the JVM client for ktor. @krzema12 thanks for finding that :D |
|
Thanks 👍 |
This dependency was accidentally removed in PR #9755 where we switched
from
build.gradletobuild.gradle.kts.Symptom of this dependency missing (not making this change):
which contains a clear message hinting what's wrong.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.3.x,6.0.xTechnical committee:
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m
People working on the previous change (#9755):
@837 @wing328