Conversation
This reverts commit 1b075ed.
Member
Author
|
Travis, Appveyor failure not related to this change. |
spacether
reviewed
Sep 9, 2021
| pyenv global 3.6.3 | ||
| python3 --version | ||
|
|
||
| mvn --no-snapshot-updates --quiet verify -Psamples.circleci.node3 -Dorg.slf4j.simpleLogger.defaultLogLevel=error |
Contributor
There was a problem hiding this comment.
Should the other circleci samples be renamed as node1, node2 etc rather than misc?
Or maybe something like node2_javasampleses
Member
Author
There was a problem hiding this comment.
Will do it in another PR instead. So many things need to be cleanup in the CI 😭
spacether
approved these changes
Sep 9, 2021
Contributor
spacether
left a comment
There was a problem hiding this comment.
Thanks for the pr! This looks good. Do you want me to merge it or do you want to?
Member
Author
|
Just merged. |
This was referenced Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
pythonclient tests to CircleCI due to low credits in other CI.cc @spacether
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xcc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)