[swift5][client] Fix module and class with same name#10387
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Sep 14, 2021
Merged
[swift5][client] Fix module and class with same name#10387wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Contributor
|
@4brunu no, I think this workaround is the best way to solve this issue at least until the bug is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes #9953
With #9624 we changed a class from #projectName#API to #projectName#.
But it seems that the Swift compiler had a bug related to projects that have a class with the same name of the module.
More details on this #9953 and https://bugs.swift.org/browse/SR-898.
This PR reverts the change from #projectName#API to #projectName#, but keeps the reference to a warning to help with the transition.
Once the transition is made, this warning can be removed with the new introduced flag
removeMigrationProjectNameClass.@aymanbagabas do you have other suggestions to fix this issue?
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)