[Kotlin] Fix default value for kotlin class#10407
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Sep 16, 2021
Merged
[Kotlin] Fix default value for kotlin class#10407wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
Contributor
|
Hey, first of all, thanks for your PR. |
Contributor
Author
Should be, I'm using case sensitive search to find |
Contributor
|
Nice, thanks, let's wait for the CI 👍 |
Contributor
Contributor
Author
|
is that search from master branch? looks like I missed one file, updated here: eaf93dc |
Contributor
|
Yes it was. |
4brunu
approved these changes
Sep 16, 2021
Contributor
4brunu
left a comment
There was a problem hiding this comment.
Looks good to me, CI failures doesn't seems to be related to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

defaultValuein mustache template which cause default value not generateddata_class_opt_var.mustachePR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xcc: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m