Skip to content

[Kotlin] Fix default value for kotlin class#10407

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
Fs02:fix-default-value-for-kotlin
Sep 16, 2021
Merged

[Kotlin] Fix default value for kotlin class#10407
wing328 merged 3 commits intoOpenAPITools:masterfrom
Fs02:fix-default-value-for-kotlin

Conversation

@Fs02
Copy link
Contributor

@Fs02 Fs02 commented Sep 16, 2021

  • Fix possible typo on kotlin defaultValue in mustache template which cause default value not generated
  • Validated on different project by overriding data_class_opt_var.mustache

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@4brunu
Copy link
Contributor

4brunu commented Sep 16, 2021

Hey, first of all, thanks for your PR.
Looks good to me.
Did you validated that you corrected all the places?
Thanks

@Fs02
Copy link
Contributor Author

Fs02 commented Sep 16, 2021

Hey, first of all, thanks for your PR.
Looks good to me.
Did you validated that you corrected all the places?
Thanks

Should be, I'm using case sensitive search to find {{defaultvalue}} in my editor
Thanks

@4brunu
Copy link
Contributor

4brunu commented Sep 16, 2021

Nice, thanks, let's wait for the CI 👍

@4brunu
Copy link
Contributor

4brunu commented Sep 16, 2021

Looks like the sample projects are not updated.
Could you please also fix those.

Screenshot 2021-09-16 at 09 58 14

And then run and commit the changes produced by those commands?

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

@Fs02
Copy link
Contributor Author

Fs02 commented Sep 16, 2021

is that search from master branch?

looks like I missed one file, updated here: eaf93dc
Thanks

@4brunu
Copy link
Contributor

4brunu commented Sep 16, 2021

Yes it was.
Thanks for the fix.
Let's wait for CI.

Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, CI failures doesn't seems to be related to this PR.

@wing328 wing328 added this to the 5.3.0 milestone Sep 16, 2021
@wing328 wing328 merged commit 0936b43 into OpenAPITools:master Sep 16, 2021
@Fs02 Fs02 deleted the fix-default-value-for-kotlin branch September 17, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants