Skip to content

[csharp-netcore] made Validate public#10413

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
GregorLamche:fix_issue10408
Sep 19, 2021
Merged

[csharp-netcore] made Validate public#10413
wing328 merged 1 commit intoOpenAPITools:masterfrom
GregorLamche:fix_issue10408

Conversation

@GregorLamche
Copy link
Contributor

@GregorLamche GregorLamche commented Sep 17, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Fix for: #10408

@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

@Blackclaws
Copy link
Contributor

Blackclaws commented Sep 17, 2021

Hold on, shouldn't they work anyway? Its explicitly implementing an interface.

https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/interfaces/explicit-interface-implementation

Therefore public is not necessary and you can validate it when casting it to IValidatableObject

You can't do:

ModelClassInstance.Validate();

You can do:

(ModelClassInstance as IValidatableObject).Validate();

It might be worth discussing whether the first one is something you'd want

@GregorLamche
Copy link
Contributor Author

As there is no second interface that has a Validate() signature there is no need for explicitly implementing the interface. The opposite actually, hiding interfaces like this, and then requiring a cast every time you use it, seems like bad practice.

@Blackclaws
Copy link
Contributor

Yeah, I get your point. I don't have any issue with the change, and I see no reason to keep the method private.

@wing328 wing328 changed the title [csharp-netcore]10408: made Validate public. [csharp-netcore] made Validate public. Sep 19, 2021
@wing328 wing328 merged commit a463c11 into OpenAPITools:master Sep 19, 2021
@wing328
Copy link
Member

wing328 commented Sep 19, 2021

@GregTheMad thanks for the contribution, which has been merged into master.

@wing328 wing328 added this to the 5.3.0 milestone Sep 19, 2021
@wing328 wing328 changed the title [csharp-netcore] made Validate public. [csharp-netcore] made Validate public Sep 19, 2021
@GregorLamche GregorLamche deleted the fix_issue10408 branch September 20, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants