[csharp-netcore] made Validate public#10413
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Sep 19, 2021
Merged
Conversation
Contributor
|
Hold on, shouldn't they work anyway? Its explicitly implementing an interface. Therefore public is not necessary and you can validate it when casting it to IValidatableObject You can't do: You can do: It might be worth discussing whether the first one is something you'd want |
Contributor
Author
|
As there is no second interface that has a |
Contributor
|
Yeah, I get your point. I don't have any issue with the change, and I see no reason to keep the method private. |
Member
|
@GregTheMad thanks for the contribution, which has been merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xFix for: #10408
@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti